[Mesa-dev] [PATCH] radv: do not emit the same reg twice in radv_emit_hw_ls()

[Samuel Pitoiset]

On 10/09/2017 11:42 AM, Dave Airlie wrote:
> That's a fix for a hw bug afaik, so nak

Ah really? So, okay.

> 
> On 9 Oct. 2017 7:25 pm, "Samuel Pitoiset" <samuel.pitoiset at gmail.com 
> <mailto:samuel.pitoiset at gmail.com>> wrote:
> 
>     Found by inspection.
> 
>     Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com
>     <mailto:samuel.pitoiset at gmail.com>>
>     ---
>       src/amd/vulkan/radv_cmd_buffer.c | 3 ---
>       1 file changed, 3 deletions(-)
> 
>     diff --git a/src/amd/vulkan/radv_cmd_buffer.c
>     b/src/amd/vulkan/radv_cmd_buffer.c
>     index f3a0a012c5..02a045aa02 100644
>     --- a/src/amd/vulkan/radv_cmd_buffer.c
>     +++ b/src/amd/vulkan/radv_cmd_buffer.c
>     @@ -684,9 +684,6 @@ radv_emit_hw_ls(struct radv_cmd_buffer *cmd_buffer,
>              radeon_emit(cmd_buffer->cs, va >> 40);
> 
>              rsrc2 |=
>     S_00B52C_LDS_SIZE(cmd_buffer->state.pipeline->graphics.tess.lds_size);
>     -       if (cmd_buffer->device->physical_device->rad_info.chip_class
>     == CIK &&
>     -           cmd_buffer->device->physical_device->rad_info.family !=
>     CHIP_HAWAII)
>     -               radeon_set_sh_reg(cmd_buffer->cs,
>     R_00B52C_SPI_SHADER_PGM_RSRC2_LS, rsrc2);
> 
>              radeon_set_sh_reg_seq(cmd_buffer->cs,
>     R_00B528_SPI_SHADER_PGM_RSRC1_LS, 2);
>              radeon_emit(cmd_buffer->cs, shader->rsrc1);
>     --
>     2.14.2
> 
>     _______________________________________________
>     mesa-dev mailing list
>     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>     <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
>