[Mesa-dev] Piglit on windows
george.kyriazis at intel.com
Tue Oct 10 15:54:00 UTC 2017
On Oct 10, 2017, at 10:41 AM, Jose Fonseca <jfonseca at vmware.com<mailto:jfonseca at vmware.com>> wrote:
On 10/10/17 16:31, Kyriazis, George wrote:
Piglit on windows prints out a message saying “Timeout are not implemented on Windows.”. These timeouts are the test timeouts in case a test hangs.
What do people do when running piglit on windows and they hit a timeout? I would imagine there would be a non-zero number of people running piglit on windows on a regular basis, as a regression tool...
I haven't been involved into piglit Windows testing lately, so my understanding might be dated.
I believe that we have timeouts when we test piglit on Windows. It's not implemented on piglit python framework itself, but rather on VMware testing framework (that driver piglit, and a bunch of other tests.)
That said, I believe it would be better long term if piglit framework had timeouts on Windows, as it can probably track that with finer granularity than we do now by putting a timeout on whole piglit or subsets of piglit tests.
Yes, definitely, that’s the way to go.
The code that I see in framework/test/base.py says:
if sys.platform == 'win32':
# There is no implementation in piglit to make timeouts work in
# windows, this uses the same Popen snippet as python 2 without
# subprocess32 to mask it. Patches are welcome.
# XXX: Should this also include cygwin?
warnings.warn('Timeouts are not implemented on Windows.')
python3's subprocess module has timeout options, so it should be relatively easy to implement on top of it, in a cross-platform manner.
Not being a python expert it looks like subprocess does not work on windows.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mesa-dev