[Mesa-dev] [AppVeyor] mesa master #5788 failed

[Jose Fonseca]

Per https://bugs.freedesktop.org/show_bug.cgi?id=103253 it's not just 
MSVC.  So I'd really recommend sticking to one of the standard C types: 
intptr_t or int64_t.

Jose

On 13/10/17 10:41, Jose Fonseca wrote:
> SSIZE_T is included on the <windows.h> headers.  We include it in most 
> places, but not necessary all.  It brings a lot of baggage, so I don't 
> recommend including it just for a ssize_t defitinion.
> 
> Instead I'd recommend replacing ssize_t in our code with plain standard 
> intptr_t.
> 
> If you really rather use ssize_t, then do
> 
>    #ifdef _WIN32
>    typedef intptr_t blob_ssize;
>    #else
>    typedef ssize_t blob_ssize;
>    #endif
> 
> at the top of blob.h and use blob_ssize on all blob_*() implementations 
> / callers.
> 
> Alternatively, if you don't care for blobs larger than 2GB, one could 
> use just int.
> 
> 
> Jose
> 
> On 13/10/17 07:05, Jason Ekstrand wrote:
>> This is aparently because MSVC doesn't have ssize_t.  How do you 
>> recommend fixing it?  I found a stack overflow comment that seems to 
>> be related here:
>>
>> https://stackoverflow.com/questions/22265610/why-ssize-t-in-visual-studio-2010-is-defined-as-unsigned 
>>
>>
>> The recommendation given in one of the answers is to import a 
>> particular header and then typedef it to SSIZE_T.  Thoughs?
>>
>> --Jason
>>
>> On Thu, Oct 12, 2017 at 9:49 PM, AppVeyor <no-reply at appveyor.com 
>> <mailto:no-reply at appveyor.com>> wrote:
>>
>>
>>       Build mesa 5788 failed
>>       <https://ci.appveyor.com/project/mesa3d/mesa/build/5788>
>>
>>     Commit b8ab78d1af by Jason Ekstrand
>>     <mailto:jason.ekstrand at intel.com> on 10/11/2017 7:13 PM:
>>     anv/pipeline_cache: Rework to use multialloc and blob\n\nThis gets
>>     rid of all of our hand-rolled size calculation and\nserialization
>>     code and replaces it with safe "standards" that are used\nelsewhere
>>     in anv and mesa. This should be significantly safer than\nrolling
>>     our own.\n\nReviewed-by: Jordan Justen <jordan.l.justen at intel.com
>>     <mailto:jordan.l.justen at intel.com>>
>>
>>     Configure your notification preferences
>>     <https://ci.appveyor.com/notifications>
>>
>>
>>     _______________________________________________
>>     mesa-dev mailing list
>>     mesa-dev at lists.freedesktop.org 
>> <mailto:mesa-dev at lists.freedesktop.org>
>>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>     <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
>>
>>
>