[Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

[Emil Velikov]

On 13 October 2017 at 18:21, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2017-10-13 07:01:24)
>> On 5 October 2017 at 20:12, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > Quoting Emil Velikov (2017-10-05 11:26:40)
>> >> On 5 October 2017 at 18:12, Dylan Baker <dylan at pnwbakers.com> wrote:
>> >> > This has the same problem as the previous commit, generated headers and
>> >> > hardcoded paths.
>> >> >
>> >> Something's strange here. You already have the "generic"
>> >>
>> >> AM_CPPFLAGS = \
>> >>    ... \
>> >>    -I$(top_builddir)/src/mapi \
>> >>    -I$(top_srcdir)/src/mapi
>> >>
>> >> ... at the top. Thus you don't need the extra -I directive, nor the
>> >> include change.
>> >> Where is the file generated with Meson?
>> >>
>> >> -Emil
>> >
>> > <builddir>/src/mapi/glapi/gen
>> >
>> In this case - everything should work like a charm.
>>
>> As-is the patch breaks the normal distcheck. So I'll revert it for now
>> and will look into fixing it properly.
>> Please try to not break !others with your meson work.
>>
>> Thanks
>> Emil
>
> Hi Emil,
>
> This patch does not break ./configure && make, which I have been testing
> whenever I make changes to autotools.
As you're changing tests, please run the check/distcheck. Pretty please?

> Your revert however, breaks the meson
> build when building tests, which we do in our CI.
>
The meson check/test target is broken even without my revert, sorry to
be the bearer of bad news.

-Emil