[Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

[Dylan Baker]

Quoting Emil Velikov (2017-10-13 10:27:38)
> On 13 October 2017 at 18:21, Dylan Baker <dylan at pnwbakers.com> wrote:
> > Quoting Emil Velikov (2017-10-13 07:01:24)
> >> On 5 October 2017 at 20:12, Dylan Baker <dylan at pnwbakers.com> wrote:
> >> > Quoting Emil Velikov (2017-10-05 11:26:40)
> >> >> On 5 October 2017 at 18:12, Dylan Baker <dylan at pnwbakers.com> wrote:
> >> >> > This has the same problem as the previous commit, generated headers and
> >> >> > hardcoded paths.
> >> >> >
> >> >> Something's strange here. You already have the "generic"
> >> >>
> >> >> AM_CPPFLAGS = \
> >> >>    ... \
> >> >>    -I$(top_builddir)/src/mapi \
> >> >>    -I$(top_srcdir)/src/mapi
> >> >>
> >> >> ... at the top. Thus you don't need the extra -I directive, nor the
> >> >> include change.
> >> >> Where is the file generated with Meson?
> >> >>
> >> >> -Emil
> >> >
> >> > <builddir>/src/mapi/glapi/gen
> >> >
> >> In this case - everything should work like a charm.
> >>
> >> As-is the patch breaks the normal distcheck. So I'll revert it for now
> >> and will look into fixing it properly.
> >> Please try to not break !others with your meson work.
> >>
> >> Thanks
> >> Emil
> >
> > Hi Emil,
> >
> > This patch does not break ./configure && make, which I have been testing
> > whenever I make changes to autotools.
> As you're changing tests, please run the check/distcheck. Pretty please?

I did run make check, which worked fine for me at the time, and works fine for
me with mesa with your revert locally reverted (well, gallium tests fail, but
those fail with your patch too). I will run dist-check in the future.

I'll fix the guards for compiler tests (which is why tests aren't built in
travis) so we can turn them on there.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171013/2c142410/attachment-0001.sig>