[Mesa-dev] [PATCH] radv: Don't free NIR shaders if tracing

Alex Smith asmith at feralinteractive.com
Wed Oct 18 14:08:20 UTC 2017


Fixes a crash while generating a hang report.

Fixes: 7d45d22fdd2e ("radv: switch to using radv_create_shaders()")
Signed-off-by: Alex Smith <asmith at feralinteractive.com>
---
 src/amd/vulkan/radv_pipeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index a3d8660eda..b27b08f6aa 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -1696,7 +1696,7 @@ void radv_create_shaders(struct radv_pipeline *pipeline,
 
 	for (int i = 0; i < MESA_SHADER_STAGES; ++i) {
 		free(codes[i]);
-		if (modules[i] && !modules[i]->nir)
+		if (modules[i] && !modules[i]->nir && !pipeline->device->trace_bo)
 			ralloc_free(nir[i]);
 	}
 
-- 
2.13.6



More information about the mesa-dev mailing list