[Mesa-dev] [PATCH] isl: Fix width check in isl_gen7_choose_msaa_layout.
Juan A. Suarez Romero
jasuarez at igalia.com
Thu Oct 19 07:42:11 UTC 2017
On Wed, 2017-10-18 at 23:23 -0700, Kenneth Graunke wrote:
> The restriction is supposed to apply if the width *field* is >= 8192,
> meaning the actual width *value* is >= 8193.
>
> The code also incorrectly used == for some reason.
Reviewed-by: Juan A. Suarez Romero <jasuarez at igalia.com>
> ---
> src/intel/isl/isl_gen7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c
> index 24d411f51e9..c42428cba7a 100644
> --- a/src/intel/isl/isl_gen7.c
> +++ b/src/intel/isl/isl_gen7.c
> @@ -132,7 +132,7 @@ isl_gen7_choose_msaa_layout(const struct isl_device *dev,
> * is >= 8192 (meaning the actual surface width is >= 8193 pixels), this
> * field must be set to MSFMT_MSS.
> */
> - if (info->samples == 8 && info->width == 8192)
> + if (info->samples == 8 && info->width > 8192)
> require_array = true;
>
> /* From the Ivybridge PRM, Volume 4 Part 1 p72, SURFACE_STATE, Multisampled
More information about the mesa-dev
mailing list