[Mesa-dev] [PATCH] isl: Fix width check in isl_gen7_choose_msaa_layout.

[Jason Ekstrand]

Rb


On October 18, 2017 11:23:44 PM Kenneth Graunke <kenneth at whitecape.org> wrote:

> The restriction is supposed to apply if the width *field* is >= 8192,
> meaning the actual width *value* is >= 8193.
>
> The code also incorrectly used == for some reason.
> ---
>  src/intel/isl/isl_gen7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c
> index 24d411f51e9..c42428cba7a 100644
> --- a/src/intel/isl/isl_gen7.c
> +++ b/src/intel/isl/isl_gen7.c
> @@ -132,7 +132,7 @@ isl_gen7_choose_msaa_layout(const struct isl_device *dev,
>      *    is >= 8192 (meaning the actual surface width is >= 8193 pixels), this
>      *    field must be set to MSFMT_MSS.
>      */
> -   if (info->samples == 8 && info->width == 8192)
> +   if (info->samples == 8 && info->width > 8192)
>        require_array = true;
>
>     /* From the Ivybridge PRM, Volume 4 Part 1 p72, SURFACE_STATE, Multisampled
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev