[Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

Timothy Arceri tarceri at itsqueeze.com
Sun Oct 22 22:17:49 UTC 2017


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 23/10/17 03:43, Bas Nieuwenhuizen wrote:
> Since it also uses the output vector before writing to memory.
> 
> Fixes: e38685cc62e 'Revert "radv: disable support for VEGA for now."'
> ---
>   src/amd/vulkan/radv_shader.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index 07e68d6032b..6176a2e590d 100644
> --- a/src/amd/vulkan/radv_shader.c
> +++ b/src/amd/vulkan/radv_shader.c
> @@ -265,9 +265,7 @@ radv_shader_compile_to_nir(struct radv_device *device,
>   		indirect_mask |= nir_var_shader_in;
>   	}
>   	if (!llvm_has_working_vgpr_indexing &&
> -	    (nir->info.stage == MESA_SHADER_VERTEX ||
> -	     nir->info.stage == MESA_SHADER_TESS_EVAL ||
> -	     nir->info.stage == MESA_SHADER_FRAGMENT))
> +	    nir->info.stage != MESA_SHADER_TESS_CTRL)
>   		indirect_mask |= nir_var_shader_out;
>   
>   	/* TODO: We shouldn't need to do this, however LLVM isn't currently
> 


More information about the mesa-dev mailing list