[Mesa-dev] [PATCH 4/5] mesa: increase MaxServerWaitTimeout

Kenneth Graunke kenneth at whitecape.org
Sun Oct 22 22:32:49 UTC 2017


On Sunday, October 22, 2017 12:18:11 PM PDT Nicolai Hähnle wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
> 
> The current value was introduced in commit a27180d0d8666, which claims
> that it represents ~1.11 years. However, it is interpreted in nanoseconds,
> so it actually only represents ~9.8 hours. That seems a bit short.
> 
> Use the largest value consistent with both int32 and int64. It
> corresponds to ~292 years in nanoseconds.
> 
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
> index 6d24b93c192..61099eb39f2 100644
> --- a/src/mesa/main/context.c
> +++ b/src/mesa/main/context.c
> @@ -647,21 +647,21 @@ _mesa_init_constants(struct gl_constants *consts, gl_api api)
>     consts->GenerateTemporaryNames = false;
>  #endif
>  
>     /* GL_ARB_framebuffer_object */
>     consts->MaxSamples = 0;
>  
>     /* GLSL default if NativeIntegers == FALSE */
>     consts->UniformBooleanTrue = FLOAT_AS_UNION(1.0f).u;
>  
>     /* GL_ARB_sync */
> -   consts->MaxServerWaitTimeout = 0x1fff7fffffffULL;
> +   consts->MaxServerWaitTimeout = 0x7fffffff7fffffffULL;

I'm not sure why I picked that value instead of the larger one :(
This looks good to me, thanks!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

>  
>     /* GL_EXT_provoking_vertex */
>     consts->QuadsFollowProvokingVertexConvention = GL_TRUE;
>  
>     /** GL_ARB_viewport_array */
>     consts->LayerAndVPIndexProvokingVertex = GL_UNDEFINED_VERTEX;
>  
>     /* GL_EXT_transform_feedback */
>     consts->MaxTransformFeedbackBuffers = MAX_FEEDBACK_BUFFERS;
>     consts->MaxTransformFeedbackSeparateComponents = 4 * MAX_FEEDBACK_ATTRIBS;
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171022/c0457888/attachment.sig>


More information about the mesa-dev mailing list