[Mesa-dev] [PATCH mesa] meson: be explicit about the version required

[Eric Engestrom]

On Tuesday, 2017-10-24 09:40:22 -0700, Dylan Baker wrote:
> This seems reasonable, could you wrap the hanging indent like meson_options with
> the closing brace on it's own line and with each option on its own line?
> ie:
> project(
>   mesa
>   ...
> )

Done

> 
> With that:
> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Thanks :)

Before I push it, there was an implied question, let's make it explicit:
Which version do we want here? How far back do we want to support Meson?

I don't know much about the history of Meson and of its features, so
I have no idea how much effort it would be to support some previous
version.

> 
> Quoting Eric Engestrom (2017-10-24 07:04:01)
> > This way, we know what we're allowed to use (no nested include lists
> > for instance) and users get immediate feedback when trying to use
> > unsupported versions, rather than a cryptic crash or things being
> > silently not built correctly.
> > 
> > Cc: Dylan Baker <dylan at pnwbakers.com>
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > ---
> >  meson.build | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 9f4812258236d6dfd72d..38038c322082f03236f2 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -18,7 +18,11 @@
> >  # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> >  # SOFTWARE.
> >  
> > -project('mesa', ['c', 'cpp'], version : '17.3.0-devel', license : 'MIT',
> > +project('mesa',
> > +        ['c', 'cpp'],
> > +        version : '17.3.0-devel',
> > +        license : 'MIT',
> > +        meson_version : '>= 0.42',
> >          default_options : ['c_std=c99', 'cpp_std=c++11'])
> >  
> >  # Arguments for the preprocessor, put these in a separate array from the C and
> > -- 
> > Cheers,
> >   Eric
> >