[Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

Eric Anholt eric at anholt.net
Sat Oct 28 06:16:47 UTC 2017


Jason Ekstrand <jason at jlekstrand.net> writes:

> On October 27, 2017 18:21:45 Matt Turner <mattst88 at gmail.com> wrote:
>
>> ... as can happen with various types like mat4, or else we'll smash the
>> stack writing past the end of components_local[].
>
> Ugh... Ideally, I think you'd want without_matrix() because a matrix is 
> just an array as far as interfaces go.  That said, I think this probably 
> fine for now.  R-b.

Oh, I thought I was getting the components-in-the-vectors, but needing
without_array should have tipped me off.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171027/3df3cec8/attachment.sig>


More information about the mesa-dev mailing list