[Mesa-dev] [PATCH mesa] i965: remove unused variable

Kenneth Graunke kenneth at whitecape.org
Mon Oct 30 16:52:35 UTC 2017


On Monday, October 30, 2017 3:37:40 AM PDT Eric Engestrom wrote:
> Fixes: 2c873060d3578c7004c0 "i965: Delete unused
>        brw_vs_prog_data::nr_attributes field."
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>  src/intel/compiler/brw_vec4.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp
> index 4a87b28822c156a6a317..c21d3f49c2ead9558d1b 100644
> --- a/src/intel/compiler/brw_vec4.cpp
> +++ b/src/intel/compiler/brw_vec4.cpp
> @@ -2815,9 +2815,6 @@ brw_compile_vs(const struct brw_compiler *compiler, void *log_data,
>        nr_attribute_slots++;
>     }
>  
> -   unsigned nr_attributes = nr_attribute_slots -
> -      DIV_ROUND_UP(_mesa_bitcount_64(shader->info.double_inputs_read), 2);
> -
>     /* The 3DSTATE_VS documentation lists the lower bound on "Vertex URB Entry
>      * Read Length" as 1 in vec4 mode, and 0 in SIMD8 mode.  Empirically, in
>      * vec4 mode, the hardware appears to wedge unless we read something.
> 

D'oh, thanks :(  I was trying to remove more things and apparently
backed out too much...

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171030/65a2babb/attachment-0001.sig>


More information about the mesa-dev mailing list