[Mesa-dev] [PATCH mesa] i965: remove unused variable

Eduardo Lima Mitev elima at igalia.com
Mon Oct 30 10:44:59 UTC 2017


I saw it this morning as well. Thanks for fixing it.

Reviewed-by: Eduardo Lima Mitev

On 10/30/2017 11:37 AM, Eric Engestrom wrote:
> Fixes: 2c873060d3578c7004c0 "i965: Delete unused
>        brw_vs_prog_data::nr_attributes field."
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>  src/intel/compiler/brw_vec4.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp
> index 4a87b28822c156a6a317..c21d3f49c2ead9558d1b 100644
> --- a/src/intel/compiler/brw_vec4.cpp
> +++ b/src/intel/compiler/brw_vec4.cpp
> @@ -2815,9 +2815,6 @@ brw_compile_vs(const struct brw_compiler *compiler, void *log_data,
>        nr_attribute_slots++;
>     }
>  
> -   unsigned nr_attributes = nr_attribute_slots -
> -      DIV_ROUND_UP(_mesa_bitcount_64(shader->info.double_inputs_read), 2);
> -
>     /* The 3DSTATE_VS documentation lists the lower bound on "Vertex URB Entry
>      * Read Length" as 1 in vec4 mode, and 0 in SIMD8 mode.  Empirically, in
>      * vec4 mode, the hardware appears to wedge unless we read something.
> 



More information about the mesa-dev mailing list