[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 5 14:12:57 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=102530

--- Comment #11 from Erik Faye-Lund <kusmabite at gmail.com> ---
(In reply to Timothy Arceri from comment #9)
> (In reply to Erik Faye-Lund from comment #8)
> > Something like this?
> > 
> > ---8<---
> > 
> > diff --git a/src/mesa/main/uniform_query.cpp
> > b/src/mesa/main/uniform_query.cpp
> > index c6488325a8..642c93270f 100644
> > --- a/src/mesa/main/uniform_query.cpp
> > +++ b/src/mesa/main/uniform_query.cpp
> > @@ -911,6 +911,9 @@ _mesa_uniform(GLint location, GLsizei count, const
> > GLvoid *values,
> >  
> >     struct gl_uniform_storage *uni;
> >     if (_mesa_is_no_error_enabled(ctx)) {
> > +      if (location == -1)
> > +         return;
> > +
> >        uni = shProg->UniformRemapTable[location];
> >  
> >        /* The array index specified by the uniform location is just the
> > 
> > ---8<---
> 
> This was already fixed.

OK, then I guess this commit was a false positive when bisecting, because it
wasn't fixed in the commit this was tested against.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170905/e114a25e/attachment.html>


More information about the mesa-dev mailing list