[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=102530

--- Comment #12 from Alexandre Demers <alexandre.f.demers at gmail.com> ---
(In reply to Erik Faye-Lund from comment #11)
> (In reply to Timothy Arceri from comment #9)
> > (In reply to Erik Faye-Lund from comment #8)
> > > Something like this?
> > > 
> > > ---8<---
> > > 
> > > diff --git a/src/mesa/main/uniform_query.cpp
> > > b/src/mesa/main/uniform_query.cpp
> > > index c6488325a8..642c93270f 100644
> > > --- a/src/mesa/main/uniform_query.cpp
> > > +++ b/src/mesa/main/uniform_query.cpp
> > > @@ -911,6 +911,9 @@ _mesa_uniform(GLint location, GLsizei count, const
> > > GLvoid *values,
> > >  
> > >     struct gl_uniform_storage *uni;
> > >     if (_mesa_is_no_error_enabled(ctx)) {
> > > +      if (location == -1)
> > > +         return;
> > > +
> > >        uni = shProg->UniformRemapTable[location];
> > >  
> > >        /* The array index specified by the uniform location is just the
> > > 
> > > ---8<---
> > 
> > This was already fixed.
> 
> OK, then I guess this commit was a false positive when bisecting, because it
> wasn't fixed in the commit this was tested against.

By the way, if it was fixed, the fix may be occulted by Bug 102502. I first
reported 102502, which kills Kodi at launch, and I ended up finding the current
bug (102530) while bisecting the first one. Fixing 102502 may show that the
current bug is already fix then.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170905/b0efc812/attachment.html>