[Mesa-dev] [PATCH] nir: put compact into bitfields in nir_variable_data

[Jason Ekstrand]

On Tue, Sep 5, 2017 at 8:19 PM, Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> This being declared bool means it won't get merged with the previous
> bitfields, this seems like an oversight rather than deliberate.
>

Really?  That's silly... This is fine with me.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> Noticed when running pahole.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/compiler/nir/nir.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
> index 9313b7ac90..8330e6d7ce 100644
> --- a/src/compiler/nir/nir.h
> +++ b/src/compiler/nir/nir.h
> @@ -220,7 +220,7 @@ typedef struct nir_variable {
>         * be tightly packed.  In other words, consecutive array elements
>         * should be stored one component apart, rather than one slot apart.
>         */
> -      bool compact:1;
> +      unsigned compact:1;
>
>        /**
>         * Whether this is a fragment shader output implicitly initialized
> with
> --
> 2.13.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170905/725f095b/attachment-0001.html>