[Mesa-dev] [PATCH 3/4] egl: use _eglError's 'msg' as an actual message in EGL_KHR_debug
Emil Velikov
emil.l.velikov at gmail.com
Thu Sep 7 16:03:52 UTC 2017
From: Emil Velikov <emil.velikov at collabora.com>
Seemingly, the original intent behind _eglError's 'msg' was aimed to
provide a function name.
At some point, people started using it the way EGL_KHR_debug's
callback() message is meant to be used. Aka providing meaningful
information to the developer/user.
Swap the funcName/msg argument order in the _eglDebugReport() call.
The 'funcName' variable is implicitly set, props to the
_eglSetFuncName() call at the start of each public entrypoint.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
src/egl/main/eglcurrent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c
index b197833e88e..7af3011b757 100644
--- a/src/egl/main/eglcurrent.c
+++ b/src/egl/main/eglcurrent.c
@@ -286,7 +286,7 @@ _eglError(EGLint errCode, const char *msg)
else
type = EGL_DEBUG_MSG_ERROR_KHR;
- _eglDebugReport(errCode, msg, type, NULL);
+ _eglDebugReport(errCode, NULL, type, msg);
} else
_eglInternalError(errCode, msg);
--
2.14.1
More information about the mesa-dev
mailing list