[Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Thu, Sep 7, 2017 at 10:53 AM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as not-rendered-to,
> the idea being that it should be marked as "rendered-to" again as soon as
> any rendering was touching the front.
>
> Now the latter part never happened, because it was part of a state
> validation and we never marked that part of the state as dirty.
>
> So mark the framebuffer state dirty after a frontbuffer flush.
> (fdo bugzilla 102496)
>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
> Tested-by: Bruce Cherniak <bruce.cherniak at intel.com>
> Tested-By: Gert Wollny <gw.fossdev at gmail.com>
> ---
>  src/mesa/state_tracker/st_manager.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c
> index 07c430d..6c7d836 100644
> --- a/src/mesa/state_tracker/st_manager.c
> +++ b/src/mesa/state_tracker/st_manager.c
> @@ -1044,6 +1044,9 @@ st_manager_flush_frontbuffer(struct st_context *st)
>        stfb->iface->flush_front(&st->iface, stfb->iface,
>                                 ST_ATTACHMENT_FRONT_LEFT);
>        strb->defined = GL_FALSE;
> +
> +      /* Trigger an update of strb->defined on next draw */
> +      st->dirty |= ST_NEW_FB_STATE;
>     }
>  }
>
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev