[Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

Kai Wasserbäch kai at dev.carbon-project.org
Thu Sep 7 16:10:01 UTC 2017


Hey Thomas,
Thomas Hellstrom wrote on 07.09.2017 10:53:
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as not-rendered-to,
> the idea being that it should be marked as "rendered-to" again as soon as
> any rendering was touching the front.
>
> Now the latter part never happened, because it was part of a state
> validation and we never marked that part of the state as dirty.
>
> So mark the framebuffer state dirty after a frontbuffer flush.
> (fdo bugzilla 102496)
>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
> Tested-by: Bruce Cherniak <bruce.cherniak at intel.com>
> Tested-By: Gert Wollny <gw.fossdev at gmail.com>

I think the customary lines for bug references and fixed commits are:

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102496
 Fixes: eceb671002 (mesa/st: Reduce the number of frontbuffer flush calls)

As those get picked up by the scripts for eg. stable management. You might want
to use those tags.

Cheers,
Kai


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170907/58f9f90e/attachment.sig>


More information about the mesa-dev mailing list