[Mesa-dev] [PATCH] radv/ac: bump params array for image atomic comp swap

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Wed Sep 13 06:59:22 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Wed, Sep 13, 2017 at 7:19 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> For the comp_swap case this was overflowing and crashing
> sometimes.
>
> Fixes:
> dEQP-VK.image.atomic_operations.compare_exchange.*
>
> Cc: "17.2" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 22e915d..1388ebd 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -3466,7 +3466,7 @@ static void visit_image_store(struct ac_nir_context *ctx,
>  static LLVMValueRef visit_image_atomic(struct ac_nir_context *ctx,
>                                         const nir_intrinsic_instr *instr)
>  {
> -       LLVMValueRef params[6];
> +       LLVMValueRef params[7];
>         int param_count = 0;
>         const nir_variable *var = instr->variables[0]->var;
>
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list