[Mesa-dev] [PATCH] radv/ac: bump params array for image atomic comp swap

Andres Gomez agomez at igalia.com
Wed Sep 13 13:36:25 UTC 2017


Hi Dave,

This patch landed tagged for 17.2 only. Was it, then, not nominated for
17.1 intentionally ?

Br.

On Wed, 2017-09-13 at 15:19 +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> For the comp_swap case this was overflowing and crashing
> sometimes.
> 
> Fixes:
> dEQP-VK.image.atomic_operations.compare_exchange.*
> 
> Cc: "17.2" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 22e915d..1388ebd 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -3466,7 +3466,7 @@ static void visit_image_store(struct ac_nir_context *ctx,
>  static LLVMValueRef visit_image_atomic(struct ac_nir_context *ctx,
>                                         const nir_intrinsic_instr *instr)
>  {
> -	LLVMValueRef params[6];
> +	LLVMValueRef params[7];
>  	int param_count = 0;
>  	const nir_variable *var = instr->variables[0]->var;
>  
-- 
Br,

Andres


More information about the mesa-dev mailing list