[Mesa-dev] [PATCH] r600: fork and import gallium/radeon
Emil Velikov
emil.l.velikov at gmail.com
Thu Sep 14 14:19:49 UTC 2017
Hi Marek,
On 14 September 2017 at 14:06, Marek Olšák <maraeo at gmail.com> wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> This marks the end of code sharing between r600 and radeonsi.
>
It has the "what" but it's missing the "why". Can you please add some
information.
>From a quick look which will make each binary ~140KiB larger (dri,
omx, vdpau ...). As a reference point drivers/r600 and
drivers/radeonsi themselves are around 620KiB and 280KiB respectively.
With the bits duplicated/forked, should one `mv radeon{,si}` or you're
planning that at a later stage?
> A lot of functions had to be renamed to prevent linker conflicts.
>
> There are also minor cleanups.
> ---
>
> This one is huge. Please review here:
> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master&id=858b2d1c8cec727fdf750192c8c210f72d38f853
>
I'll look at those in an hour or so.
-Emil
More information about the mesa-dev
mailing list