[Mesa-dev] [PATCH] r600: fork and import gallium/radeon

[Nicolai Hähnle]

On 14.09.2017 16:19, Emil Velikov wrote:
> Hi Marek,
> 
> On 14 September 2017 at 14:06, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> This marks the end of code sharing between r600 and radeonsi.
>>
> It has the "what" but it's missing the "why". Can you please add some
> information.

Basically, it's getting difficult to work on radeonsi without breaking r600.

It's not ideal, but (1) without a solid testing infrastructure that 
tests all the way back to r600, this is a reasonable measure to reduce 
the development risk, and (2) with some rare exceptions, our work on 
radeonsi tends not to help r600, neither in performance nor in features 
(and least of all bug fixes).

I haven't looked at the patch itself yet, but I'm okay with the general 
idea.

Cheers,
Nicolai

>  From a quick look which will make each binary ~140KiB larger (dri,
> omx, vdpau ...). As a reference point drivers/r600 and
> drivers/radeonsi themselves are around 620KiB and 280KiB respectively.
> 
> With the bits duplicated/forked, should one `mv radeon{,si}` or you're
> planning that at a later stage?
> 
>> A lot of functions had to be renamed to prevent linker conflicts.
>>
>> There are also minor cleanups.
>> ---
>>
>> This one is huge. Please review here:
>> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master&id=858b2d1c8cec727fdf750192c8c210f72d38f853
>>
> I'll look at those in an hour or so.
> 
> -Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.