[Mesa-dev] [PATCH 2/3] intel/blorp/hiz: Always set sample number

[Kenneth Graunke]

On Monday, September 11, 2017 5:48:25 AM PDT Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/intel/blorp/blorp_genX_exec.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h
> index 5f9a8ab4a5..5389262098 100644
> --- a/src/intel/blorp/blorp_genX_exec.h
> +++ b/src/intel/blorp/blorp_genX_exec.h
> @@ -1454,6 +1454,17 @@ blorp_emit_gen8_hiz_op(struct blorp_batch *batch,
>     if (params->stencil.enabled)
>        assert(params->hiz_op == BLORP_HIZ_OP_DEPTH_CLEAR);
>  
> +   /* From the BDW PRM Volume 2, 3DSTATE_WM_HZ_OP:
> +    *
> +    * 3DSTATE_MULTISAMPLE packet must be used prior to this packet to change
> +    * the Number of Multisamples. This packet must not be used to change
> +    * Number of Multisamples in a rendering sequence.
> +    *
> +    * Since HIZ may be the first thing in a batch buffer, play safe and always
> +    * emit 3DSTATE_MULTISAMPLE.
> +    */
> +   blorp_emit_3dstate_multisample(batch, params);
> +
>     /* If we can't alter the depth stencil config and multiple layers are
>      * involved, the HiZ op will fail. This is because the op requires that a
>      * new config is emitted for each additional layer.
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170914/f8451d67/attachment.sig>