[Mesa-dev] [PATCH 7/7] wayland-egl: rework and simplify wl_egl_window initialization

Miguel Angel Vico mvicomoya at nvidia.com
Fri Sep 29 20:40:57 UTC 2017


> Miguel I believe the comment correctly describes the design plan, while
> addressing Dan's comment that things look a bit ugly.

Yes. Thank you.

Also, the whole series:

Reviewed-by: Miguel A. Vico <mvicomoya at nvidia.com>


Thanks.

On Fri, 29 Sep 2017 14:48:58 +0100
Daniel Stone <daniel at fooishbar.org> wrote:

> On 29 September 2017 at 13:14, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > Use calloc instead of malloc + explicitly zeroing the different fields.
> > We need special handling for the version field which if of type
> > const intptr_t.
> >
> > As we're here document why keeping the constness is a good idea.
> >
> > The wl_egl_window_resize() call is replaced with an explicit set of the
> > width/height.  
> 
> Thanks for doing this; series is:
> Reviewed-by: Daniel Stone <daniels at collabora.com>
> 
> Cheers,
> Daniel
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


-- 
Miguel




More information about the mesa-dev mailing list