[Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

[Marek Olšák]

On Mon, Apr 9, 2018 at 10:51 AM, Bas Vermeulen <bas at daedalean.ai> wrote:

> I am working on a new version of this patch. I have one version which does
> away with all the bitfields, and uses
> functions to update the index.
> Another approach would be to change the union to a struct, and use a
> function to get the index.
> Yet another approach would be to keep the contents of the union and the
> index in one struct, and use a function to
> (re)calculate the index.
>
> Which would you prefer?
>

I don't mind bitfields. They make the code nice and tiny. Shifts would
decrease readability.

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180409/5da8a5f3/attachment.html>