[Mesa-dev] [PATCH] anv: fix number of planes for depth & stencil

[Lionel Landwerlin]

It's supposed to depend on how many aspects you've selected for creating 
the image view (not always correlate to the image).

On 12/04/18 14:15, Jason Ekstrand wrote:
> I don't really get what this patch is doing.  Why not just use 
> image->n_planes?
>
> On Thu, Apr 12, 2018 at 11:37 AM, Lionel Landwerlin 
> <lionel.g.landwerlin at intel.com <mailto:lionel.g.landwerlin at intel.com>> 
> wrote:
>
>     We're not counting correctly with depth & stencil images.
>
>     Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com
>     <mailto:lionel.g.landwerlin at intel.com>>
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105994
>     <https://bugs.freedesktop.org/show_bug.cgi?id=105994>
>     ---
>      src/intel/vulkan/anv_private.h | 4 ++++
>      1 file changed, 4 insertions(+)
>
>     diff --git a/src/intel/vulkan/anv_private.h
>     b/src/intel/vulkan/anv_private.h
>     index 53115ae470f..a4297511bbb 100644
>     --- a/src/intel/vulkan/anv_private.h
>     +++ b/src/intel/vulkan/anv_private.h
>     @@ -2356,6 +2356,10 @@
>     anv_image_aspect_get_planes(VkImageAspectFlags aspect_mask)
>         if (aspect_mask & VK_IMAGE_ASPECT_PLANE_2_BIT)
>            planes++;
>
>     +   if (aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT &&
>     +       aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)
>     +      planes++;
>     +
>         return planes;
>      }
>
>     --
>     2.17.0
>
>     _______________________________________________
>     mesa-dev mailing list
>     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>     <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180412/47daa62c/attachment.html>