[Mesa-dev] [PATCH] i965/fs: Return mlen * 8 for size_written for INTERPOLATE_AT_*

[Jason Ekstrand]

On Mon, Apr 23, 2018 at 1:36 PM, Francisco Jerez <currojerez at riseup.net>
wrote:

> Jason Ekstrand <jason at jlekstrand.net> writes:
>
> > They are send messages and this makes size_written() and mlen agree.
>
> You mean size_read()?  And commit message should probably read "Return
> mlen * 32 for size_read for INTERPOLATE_AT_*" to reflect what the commit
> is doing.
>

Yes.  That was a typo.


> > For both of these opcodes, the payload is just a dummy so mlen == 1 and
> > this should decrease register pressure a bit.
> >
>
> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
>

Thanks!


> > Cc: Francisco Jerez <currojerez at riseup.net>
> > Cc: mesa-stable at lists.freedesktop.org
> > ---
> >  src/intel/compiler/brw_fs.cpp | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.
> cpp
> > index 40896db..8156507 100644
> > --- a/src/intel/compiler/brw_fs.cpp
> > +++ b/src/intel/compiler/brw_fs.cpp
> > @@ -842,6 +842,8 @@ fs_inst::size_read(int arg) const
> >     case SHADER_OPCODE_TYPED_ATOMIC:
> >     case SHADER_OPCODE_TYPED_SURFACE_READ:
> >     case SHADER_OPCODE_TYPED_SURFACE_WRITE:
> > +   case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> > +   case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:
> >     case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:
> >     case SHADER_OPCODE_BYTE_SCATTERED_WRITE:
> >     case SHADER_OPCODE_BYTE_SCATTERED_READ:
> > --
> > 2.5.0.400.gff86faf
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180423/28bd2eba/attachment-0001.html>