[Mesa-dev] [PATCH] ac/nir: set lod to 0 when it's unused

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Apr 26 10:17:05 UTC 2018


Otherwise we hit an assertion in ac_build_image_opcode()
for ac_image_load_mip.

Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for image intrinsics")
Cc: 18.1 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/common/ac_nir_to_llvm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index e4ae6ef49ad..08ee81611e3 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -1276,6 +1276,8 @@ static LLVMValueRef build_tex_intrinsic(struct ac_nir_context *ctx,
 		args->opcode = args->level_zero ||
 			       instr->sampler_dim == GLSL_SAMPLER_DIM_MS ?
 					ac_image_load : ac_image_load_mip;
+		if (!args->lod)
+			args->lod = ctx->ac.i32_0;
 		args->level_zero = false;
 		break;
 	case nir_texop_txs:
-- 
2.17.0



More information about the mesa-dev mailing list