[Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

[Emil Velikov]

On 8 August 2018 at 17:29, Marek Olšák <maraeo at gmail.com> wrote:
> On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 8 August 2018 at 12:04, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 8 August 2018 at 06:42, Marek Olšák <maraeo at gmail.com> wrote:
>>>> From: Marek Olšák <marek.olsak at amd.com>
>>>>
>>>> This is needed for exposing the samplerBuffer functions under
>>>> EXT_gpu_shader4.
>>>>
>>>> glTexBufferEXT is defined in glapi, but "make check" fails.
>>>> What am I doing wrong?
>>> There should be one in src/mapi/glapi/gen/
>>> One of these days we should stop rolling our own and use the canonical
>>> registry/gl.xlm
>>>
>>> Until then, make a separate xml file - see for example
>>> a0d6732182ee62834993187e8cbd84fa4e03d786
>>>
>> To elaborate a bit:
>>
>> Here you're adding the desktop GL extension EXT_texture_buffer_object.
>> Where currently we have only the ES one EXT_texture_buffer in
>> es_EXT.xml.
>> Hence the aliasing you have in there will be applicable only for GLES,
>> and for said extension.
>>
>> That is, unless I'm completely loosing my marbles ;-)
>
> All XML files are included by gl_and_es_API.xml, so they are merged.
> As far as I can see, the XML files don't have the option to expose
> functions in ES only. apiexec.py can do it, but not for aliases like
> glTexBufferEXT, i.e. if glTexBuffer is available in the API, all its
> aliases are also available (ARB, EXT, OES).
>
Interesting - was under the impression that only "es" allias will be created.

Thanks for the correction.
Emil