[Mesa-dev] [PATCH v2 11/11] intel: aubinator_viewer: add urb view

[Lionel Landwerlin]

On 08/08/18 22:09, Rafael Antognolli wrote:
>> +         /* URB allocation */
>> +         hovered = _Hovered(mouse_pos, window_hovered, alloc_tl, alloc_br);
>> +         ImGui::ColorConvertHSVtoRGB((2 * s) * 1.0f / (2 * n_stages),
>> +                                     1.0f, hovered ? 1.0f : 0.8f,
>> +                                     r, g, b);
>> +         draw_list->AddRectFilled(alloc_tl, alloc_br, ImColor(r, g, b));
>> +         if (hovered) {
>> +            ImGui::SetTooltip("%s: start=%u end=%u",
>> +                              stage_names[s],
>> +                              stages[s].start,
>> +                              stages[s].n_entries * stages[s].size);
> Maybe you should add stages[s].start to the "end" case? It seems
> a little inconsistent right now.
>
> Other than that, and taking into account how much I understand about
> imgui, consider this:
>
> Reviewed-by: Rafael Antognolli<rafael.antognolli at intel.com>
>
Oh indeed, my bad!

-

Lionel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180808/40522511/attachment.html>