[Mesa-dev] [PATCH 01/10] spirv: fill info.gs.input_primitive too

Timothy Arceri tarceri at itsqueeze.com
Mon Aug 13 02:35:37 UTC 2018


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 09/08/18 23:43, Alejandro PiƱeiro wrote:
> info.gs.output_primitive was already being filled. Not sure why this
> is not needed on Vulkan, but we found to be needed for
> ARB_gl_spirv. Specifically, this is needed to get the following test
> passing:
> 
> KHR-GL45.gl_spirv.spirv_validation_builtin_variable_decorations_test
> ---
>   src/compiler/spirv/spirv_to_nir.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
> index 32ebdd78a1f..b5ec2de7bf9 100644
> --- a/src/compiler/spirv/spirv_to_nir.c
> +++ b/src/compiler/spirv/spirv_to_nir.c
> @@ -3690,6 +3690,8 @@ vtn_handle_execution_mode(struct vtn_builder *b, struct vtn_value *entry_point,
>            vtn_assert(b->shader->info.stage == MESA_SHADER_GEOMETRY);
>            b->shader->info.gs.vertices_in =
>               vertices_in_from_spv_execution_mode(b, mode->exec_mode);
> +         b->shader->info.gs.input_primitive =
> +            gl_primitive_from_spv_execution_mode(b, mode->exec_mode);
>         }
>         break;
>   
> 


More information about the mesa-dev mailing list