[Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

[Sagar Ghuge]

On 08/13/2018 03:43 PM, Ian Romanick wrote:
> On 08/09/2018 01:14 PM, Sagar Ghuge wrote:
>>
>>
>> On 08/09/2018 01:09 PM, Marek Olšák wrote:
>>> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge <sagar.ghuge at intel.com> wrote:
>>>> enable _mesa_PushAttrib() and _mesa_PopAttrib()
>>>> to handle GL_DEPTH_CLAMP_NEAR_AMD and
>>>> GL_DEPTH_CLAMP_FAR_AMD tokens.
>>>>
>>>> Signed-off-by: Sagar Ghuge <sagar.ghuge at intel.com>
>>>> ---
>>>>  src/mesa/main/attrib.c | 16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c
>>>> index cbe93ab6fa..d9f165b428 100644
>>>> --- a/src/mesa/main/attrib.c
>>>> +++ b/src/mesa/main/attrib.c
>>>> @@ -73,6 +73,8 @@ struct gl_enable_attrib
>>>>     GLboolean ColorMaterial;
>>>>     GLboolean CullFace;
>>>>     GLboolean DepthClamp;
>>>> +   GLboolean DepthClampNear;
>>>> +   GLboolean DepthClampFar;
>>>
>>> The first patch uses this. Also, DepthClamp can be removed, because
>>> DepthClampNear+Far replace it, right?
>>
>> Yes, that's true. 
> 
> Since this is your first significant patch series... we have an
> unwritten (maybe actually written somewhere?) rule that a patch series
> should build at every commit.  If a patch in the middle of a series
> doesn't build, doing git-bisect on a (possibly unrelated) later problem
> can be very painful.
> 

Okay, I will make sure that when I send
new patch series it should build on every commit. 

>>> Marek
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev