[Mesa-dev] [PATCH 3/8] mesa: expose AMD_multi_draw_indirect

[Ian Romanick]

This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 08/08/2018 07:12 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> because the closed driver exposes it.
> This is equivalent to the ARB extension.
> ---
>  docs/relnotes/18.3.0.html                |  1 +
>  src/mapi/glapi/gen/ARB_draw_indirect.xml | 20 ++++++++++++++++++++
>  src/mesa/main/extensions_table.h         |  1 +
>  3 files changed, 22 insertions(+)
> 
> diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html
> index 840a336d41a..cf3bb80ceae 100644
> --- a/docs/relnotes/18.3.0.html
> +++ b/docs/relnotes/18.3.0.html
> @@ -46,20 +46,21 @@ TBD.
>  
>  <h2>New features</h2>
>  
>  <p>
>  Note: some of the new features are only available with certain drivers.
>  </p>
>  
>  <ul>
>  <li>GL_AMD_framebuffer_multisample_advanced on radeonsi.</li>
>  <li>GL_AMD_gpu_shader_int64 on i965, nvc0, radeonsi.</li>
> +<li>GL_AMD_multi_draw_indirect on all GL 4.x drivers.</li>
>  <li>GL_EXT_window_rectangles on radeonsi.</li>
>  </ul>
>  
>  <h2>Bug fixes</h2>
>  
>  <ul>
>  <li>TBD</li>
>  </ul>
>  
>  <h2>Changes</h2>
> diff --git a/src/mapi/glapi/gen/ARB_draw_indirect.xml b/src/mapi/glapi/gen/ARB_draw_indirect.xml
> index 3b29d6b8674..b4399f1e8b6 100644
> --- a/src/mapi/glapi/gen/ARB_draw_indirect.xml
> +++ b/src/mapi/glapi/gen/ARB_draw_indirect.xml
> @@ -35,11 +35,31 @@
>          <param name="mode" type="GLenum"/>
>          <param name="type" type="GLenum"/>
>          <param name="indirect" type="const GLvoid *"/>
>          <param name="primcount" type="GLsizei"/>
>          <param name="stride" type="GLsizei"/>
>      </function>
>  
>  </category>
>  
>  
> +<category name="GL_AMD_multi_draw_indirect" number="408">
> +
> +    <function name="MultiDrawArraysIndirectAMD" exec="dynamic" alias="MultiDrawArraysIndirect">
> +        <param name="mode" type="GLenum"/>
> +        <param name="indirect" type="const GLvoid *"/>
> +        <param name="primcount" type="GLsizei"/>
> +        <param name="stride" type="GLsizei"/>
> +    </function>
> +
> +    <function name="MultiDrawElementsIndirectAMD" exec="dynamic" alias="MultiDrawElementsIndirect">
> +        <param name="mode" type="GLenum"/>
> +        <param name="type" type="GLenum"/>
> +        <param name="indirect" type="const GLvoid *"/>
> +        <param name="primcount" type="GLsizei"/>
> +        <param name="stride" type="GLsizei"/>
> +    </function>
> +
> +</category>
> +
> +
>  </OpenGLAPI>
> diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
> index 326fa6dc473..cc996d5d254 100644
> --- a/src/mesa/main/extensions_table.h
> +++ b/src/mesa/main/extensions_table.h
> @@ -5,20 +5,21 @@
>  #define ES1 0
>  #define ES2 0
>  #define  x ~0
>  
>  EXT(3DFX_texture_compression_FXT1           , TDFX_texture_compression_FXT1          , GLL, GLC,  x ,  x , 1999)
>  
>  EXT(AMD_conservative_depth                  , ARB_conservative_depth                 , GLL, GLC,  x ,  x , 2009)
>  EXT(AMD_draw_buffers_blend                  , ARB_draw_buffers_blend                 , GLL, GLC,  x ,  x , 2009)
>  EXT(AMD_framebuffer_multisample_advanced    , AMD_framebuffer_multisample_advanced   , GLL, GLC,  x , ES2, 2018)
>  EXT(AMD_gpu_shader_int64                    , ARB_gpu_shader_int64                   ,  x , GLC,  x ,  x , 2015)
> +EXT(AMD_multi_draw_indirect                 , ARB_draw_indirect                      , GLL, GLC,  x ,  x , 2011)
>  EXT(AMD_performance_monitor                 , AMD_performance_monitor                , GLL, GLC,  x , ES2, 2007)
>  EXT(AMD_pinned_memory                       , AMD_pinned_memory                      , GLL, GLC,  x ,  x , 2013)
>  EXT(AMD_seamless_cubemap_per_texture        , AMD_seamless_cubemap_per_texture       , GLL, GLC,  x ,  x , 2009)
>  EXT(AMD_shader_stencil_export               , ARB_shader_stencil_export              , GLL, GLC,  x ,  x , 2009)
>  EXT(AMD_shader_trinary_minmax               , dummy_true                             , GLL, GLC,  x ,  x , 2012)
>  EXT(AMD_vertex_shader_layer                 , AMD_vertex_shader_layer                , GLL, GLC,  x ,  x , 2012)
>  EXT(AMD_vertex_shader_viewport_index        , AMD_vertex_shader_viewport_index       , GLL, GLC,  x ,  x , 2012)
>  
>  EXT(ANDROID_extension_pack_es31a            , ANDROID_extension_pack_es31a           ,  x ,  x ,  x ,  31, 2014)
>  
>