[Mesa-dev] [PATCH 00/13] Implement INTEL_shader_atomic_float_minmax

[Caio Marcelo de Oliveira Filho]

> The code is here:
> 
>     https://cgit.freedesktop.org/~idr/mesa/log/?h=INTEL_shader_atomic_float_minmax

The series is

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>


I'd consider adding some clarification about not quietizing sNaN
and/or relaxing the definition in the spec (patch 3).



> and the tests are here:
> 
>     https://cgit.freedesktop.org/~idr/piglit/log/?h=INTEL_shader_atomic_float_minmax

The series (7 patches prefixed with intel_...) is

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>

given comments below for individual patches are addressed

Patch 2: typo "bit" instead of "but" in the bootstrapping comment
block.

Patch 6: the test calls floatBitsToUint(atomicCompSwap(...)), but the
result of the conversion is not used, maybe take it off.

Patch 7: typos in the commit message "quite NaN" ("quiet NaN") and
"cognitave" (instead of "cognitive"). Would consider early return if
already_set_color is set.



Thanks,
Caio