[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Aug 28 15:05:06 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=107146

--- Comment #3 from Alok Hota <alok.hota at intel.com> ---
(In reply to Bernhard Rosenkraenzer from comment #0)
> createInstructionSimplifierPass() has been removed in LLVM. This is used in
> a few places in SWR; looks like this can safely be removed because it is
> always preceded by createInstructionCombiningPass() which seems to be a
> superset of what createInstructionSimplifierPass() used to do.
> 
> Fixing this just unmasks another problem though -
> Intrinsic::x86_fma_vfmadd_ps_256 is gone. Not sure how to replace that
> properly.

I can confirm we're seeing this issue as well.

(In reply to Philip Meulengracht from comment #2)
> Created attachment 140731 [details] [review]
> proposed patch
> 
> See my attachment for a proposed patch - I encounted this error too and
> removed the references to the vfmaddps, and I removed the SimplePass's due
> to them being unnecessary. Please feel free to correct me or the patch if
> it's wrong. 
> 
> Instead of the vfmaddps it will use mul add.

Thanks for the patch! I'm looking into this now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180828/dc08c0cc/attachment-0001.html>


More information about the mesa-dev mailing list