[Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

[Eric Engestrom]

Ping?

I think we should land this now, ie. for 18.3.

By the time Mesa 18.3 comes out (probably December '18), Meson 0.45 will
be 9 months old (March '18), so I think this is reasonable.

(btw, the currently-required Meson 0.44.1 was released less than 12 days
before 0.45, so we're really not bumping by much.)

If there isn't any objection by next week, I'll push this.


On Tuesday, 2018-07-17 15:24:55 +0100, Eric Engestrom wrote:
> Cc: Rob Clark <robdclark at gmail.com>
> Cc: Jan Alexander Steffens (heftig) <jan.steffens at gmail.com>
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index c62cdd0e395259ec984e..eb90f4cf9b265435fb19 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -25,8 +25,8 @@ project(
>      [find_program('python', 'python2', 'python3'), 'bin/meson_get_version.py']
>    ).stdout(),
>    license : 'MIT',
> -  meson_version : '>= 0.44.1',
> -  default_options : ['buildtype=debugoptimized', 'c_std=c99', 'cpp_std=c++11']
> +  meson_version : '>= 0.45',
> +  default_options : ['buildtype=debugoptimized', 'b_ndebug=if-release', 'c_std=c99', 'cpp_std=c++11']
>  )
>  
>  cc = meson.get_compiler('c')
> -- 
> Cheers,
>   Eric