[Mesa-dev] [PATCH] radv: use 3d shader for gfx9 copies if dst is 3d

Samuel Pitoiset samuel.pitoiset at gmail.com
Mon Dec 3 08:13:50 UTC 2018


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 12/3/18 5:38 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This fixes some crucible 3d miptree tests I've been working on
> when executed using the compute shader path.
> 
> Fixes: d08f267814 (radv/gfx9: fix 3d image to image transfers on compute queues.)
> ---
>   src/amd/vulkan/radv_meta_bufimage.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_bufimage.c b/src/amd/vulkan/radv_meta_bufimage.c
> index f5b68f6c9a6..e0dc7151556 100644
> --- a/src/amd/vulkan/radv_meta_bufimage.c
> +++ b/src/amd/vulkan/radv_meta_bufimage.c
> @@ -2061,7 +2061,7 @@ radv_meta_image_to_image_cs(struct radv_cmd_buffer *cmd_buffer,
>   	itoi_bind_descriptors(cmd_buffer, &src_view, &dst_view);
>   
>   	if (device->physical_device->rad_info.chip_class >= GFX9 &&
> -	    src->image->type == VK_IMAGE_TYPE_3D)
> +	    (src->image->type == VK_IMAGE_TYPE_3D || dst->image->type == VK_IMAGE_TYPE_3D))
>   		pipeline = cmd_buffer->device->meta_state.itoi.pipeline_3d;
>   	radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
>   			     VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
> 


More information about the mesa-dev mailing list