[Mesa-dev] [Mesa-stable] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

[Juan A. Suarez Romero]

On Tue, 2018-12-04 at 07:47 -0800, Matt Turner wrote:
> On Tue, Dec 4, 2018 at 3:15 AM Juan A. Suarez Romero
> <jasuarez at igalia.com> wrote:
> > On Mon, 2018-12-03 at 15:38 -0800, Matt Turner wrote:
> > > On Mon, Dec 3, 2018 at 8:12 AM Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > > > On Thu, 29 Nov 2018 at 23:54, Matt Turner <mattst88 at gmail.com> wrote:
> > > > > This extension is not properly tested (testing for
> > > > > GL_ARB_fragment_shader_interlock is not sufficient), and since this was
> > > > > noted in review on August 28th no tests have been sent.
> > > > > 
> > > > > Revert "i965: Add INTEL_fragment_shader_ordering support."
> > > > > Revert "mesa: Add GL/GLSL plumbing for INTEL_fragment_shader_ordering"
> > > > > 
> > > > > This reverts commit 03ecec9ed2099f6e2b62994b33dc948dc731e7b8.
> > > > > This reverts commit 119435c8778dd26cb7c8bcde9f04b3982239fe60.
> > > > > 
> > > > Kind of unfortunate but I can see where you're coming from.
> > > > No tests, thus one cannot verify the extension works correctly and
> > > > ensures it stays OK.
> > > > 
> > > > Fwiw I couldn't spot any dEQP tests either :-(
> > > > 
> > > > > Cc: mesa-stable at lists.freedesktop.org
> > > > > ---
> > > > > Emil: I just noticed that this was never reverted from master (and it
> > > > > needs to be removed before the 18.3 release)
> > > > > 
> > > > Are you planning to push this to master? Or you'd like it reverted
> > > > only for the 18.3 branch?
> > > 
> > > Just pushed to master. Please include in 18.3.
> > 
> > This was committed without explicitly CCing to 18.3 stable release, so it is
> > shown as a candidate to 18.2 stable release too.
> 
> Hm, I thought that the scripts read the "This reverts commit $SHA1"
> and did the right thing. Or was it my Cc: mesa-stable that caused the
> confusion?


Yes, was the mesa-stable that caused the confusion.


There is no problem, just telling because my duty is to tell people when
anything is added in the cherry-ignore :)


	J.A.

> 
> > As I think this is not what we want, I'll ignore this commit for 18.2.
> 
> Right, thanks.
>