[Mesa-dev] [Mesa-stable] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

Emil Velikov emil.l.velikov at gmail.com
Wed Dec 5 18:31:18 UTC 2018


On Mon, 3 Dec 2018 at 23:38, Matt Turner <mattst88 at gmail.com> wrote:
>
> On Mon, Dec 3, 2018 at 8:12 AM Emil Velikov <emil.l.velikov at gmail.com> wrote:
> >
> > On Thu, 29 Nov 2018 at 23:54, Matt Turner <mattst88 at gmail.com> wrote:
> > >
> > > This extension is not properly tested (testing for
> > > GL_ARB_fragment_shader_interlock is not sufficient), and since this was
> > > noted in review on August 28th no tests have been sent.
> > >
> > > Revert "i965: Add INTEL_fragment_shader_ordering support."
> > > Revert "mesa: Add GL/GLSL plumbing for INTEL_fragment_shader_ordering"
> > >
> > > This reverts commit 03ecec9ed2099f6e2b62994b33dc948dc731e7b8.
> > > This reverts commit 119435c8778dd26cb7c8bcde9f04b3982239fe60.
> > >
> > Kind of unfortunate but I can see where you're coming from.
> > No tests, thus one cannot verify the extension works correctly and
> > ensures it stays OK.
> >
> > Fwiw I couldn't spot any dEQP tests either :-(
> >
> > > Cc: mesa-stable at lists.freedesktop.org
> > > ---
> > > Emil: I just noticed that this was never reverted from master (and it
> > > needs to be removed before the 18.3 release)
> > >
> > Are you planning to push this to master? Or you'd like it reverted
> > only for the 18.3 branch?
>
> Just pushed to master. Please include in 18.3.

Picked for 18.3 as well as the follow-up commit
dd53bb7e1f69740a5712decbae79dc79df8ecaa1

Thanks
Emil


More information about the mesa-dev mailing list