[Mesa-dev] [PATCH 12/59] intel/compiler: handle b2i/b2f with other integer conversion opcodes

[Jason Ekstrand]

This'll have to be rebased on dca6cd9ce6510 but otherwise looks fine.  I've
been a bit annoyed by this myself.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Incidentally, this could also be lowered in NIR.... Not sure if we want to
but there it is.

On Tue, Dec 4, 2018 at 1:18 AM Iago Toral Quiroga <itoral at igalia.com> wrote:

> Since we handle booleans as integers this makes more sense.
> ---
>  src/intel/compiler/brw_fs_nir.cpp | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs_nir.cpp
> b/src/intel/compiler/brw_fs_nir.cpp
> index 9f3d3bf9762..6c765fc2661 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -801,11 +801,6 @@ fs_visitor::nir_emit_alu(const fs_builder &bld,
> nir_alu_instr *instr)
>        inst->saturate = instr->dest.saturate;
>        break;
>
> -   case nir_op_b2i:
> -   case nir_op_b2f:
> -      op[0].type = BRW_REGISTER_TYPE_D;
> -      op[0].negate = !op[0].negate;
> -      /* fallthrough */
>     case nir_op_f2f64:
>     case nir_op_f2i64:
>     case nir_op_f2u64:
> @@ -850,6 +845,11 @@ fs_visitor::nir_emit_alu(const fs_builder &bld,
> nir_alu_instr *instr)
>        inst->saturate = instr->dest.saturate;
>        break;
>
> +   case nir_op_b2i:
> +   case nir_op_b2f:
> +      op[0].type = BRW_REGISTER_TYPE_D;
> +      op[0].negate = !op[0].negate;
> +      /* fallthrough */
>     case nir_op_i2f64:
>     case nir_op_i2i64:
>     case nir_op_u2f64:
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181207/9f0e02d6/attachment.html>