[Mesa-dev] Let's talk about -DDEBUG

[Dylan Baker]

In the autotools discussion I've come to realize that we also need to talk about
the -DDEBUG guard. It seems that there are two different uses, and thus two
different asks about it:

- Nine (and RadeonSI?) use -DDEBUG to hide generic debugging
- NIR and Intel (at least) use -DDEBUG to hide really expensive checks that are
  useful, but necessarily tank performance.

The first group would like -DDEBUG in debugoptimized builds, the second
obviously doesn't.

Is the right solution to move the first group being !NDEBUG, or would it be
better to split DEBUG into two different defines such as DEBUG_MESSAGES and
EXPENSIVE_VALIDATION (paint the bikeshed whatever color you like), with the
first for both debug and debugoptimized and the second only in debug builds?

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181212/2390598d/attachment.sig>