[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

[Alex Deucher]

On Thu, Dec 13, 2018 at 11:41 AM Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>
>> On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher <alexdeucher at gmail.com> wrote:
>> >
>> > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset
>> > <samuel.pitoiset at gmail.com> wrote:
>> > >
>> > > Personally, I will continue to use the list, at least for a simplicity
>> > > point of view. I'm not sure if using a new tool will improve quality and
>> > > code review process.
>> > >
>> > > Though, if the majority reports that is really nice to use, I will
>> > > probably change my mind. Not a strong reject.
>> >
>> > I agree.  We've been using the MR interface for xf86-video-amdgpu and
>> > I find it awkward compared to the mailing list.  Maybe it just takes
>> > getting used to.  I also feel less inclined to do drive by patch
>> > review if I have to explicitly delve into the browser to look at the
>> > outstanding MRs.  Over email, sometimes I see a patch set in my in box
>> > that piques my interest and I find some time to review it when I might
>> > not have otherwise if the bar were higher.
>>
>> FWIW I also do a lot of drive-by reviews. Perhaps those aren't
>> valuable -- dunno. Either way, if it's not in email, I won't end up
>> seeing it.
>
>
> I find this commentary on drive-by reviews interesting.  Personally, I don't find going to the web interface to be a problem at all but that may be because my e-mail is also in my web browser and it's as easy as clicking a link.  Also, since I'm an active contributor who's likely to be making MRs and commenting on various MRs on a regular basis, I'm already on the MR page looking at it.  If you randomly scrolled through the MR list in the same way you randomly scroll through the mailing list, would you be equally inclined to give drive-by reviews?  That's an honest hypothetical question.
>

I'm still very much email driven and most of the projects I work most
in are still email based.  I think the problem is that you don't see
the patches, just the MR list so you have to kind of guess based on
the MR names. When I'm reading through email, a function name or
something in a patch title may catch my eye and I'll then take a look
at that patch and probably the whole series.  E.g., "oh, they are
changing foo(), I just did some work there a few weeks ago, let me
take a look..", whereas the MR title may be something like
"Restructure to support new extension BAR." which I may not really be
too familiar with.

Alex