[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

[Ilia Mirkin]

On Thu, Dec 13, 2018 at 11:41 AM Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>
>> On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher <alexdeucher at gmail.com> wrote:
>> >
>> > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset
>> > <samuel.pitoiset at gmail.com> wrote:
>> > >
>> > > Personally, I will continue to use the list, at least for a simplicity
>> > > point of view. I'm not sure if using a new tool will improve quality and
>> > > code review process.
>> > >
>> > > Though, if the majority reports that is really nice to use, I will
>> > > probably change my mind. Not a strong reject.
>> >
>> > I agree.  We've been using the MR interface for xf86-video-amdgpu and
>> > I find it awkward compared to the mailing list.  Maybe it just takes
>> > getting used to.  I also feel less inclined to do drive by patch
>> > review if I have to explicitly delve into the browser to look at the
>> > outstanding MRs.  Over email, sometimes I see a patch set in my in box
>> > that piques my interest and I find some time to review it when I might
>> > not have otherwise if the bar were higher.
>>
>> FWIW I also do a lot of drive-by reviews. Perhaps those aren't
>> valuable -- dunno. Either way, if it's not in email, I won't end up
>> seeing it.
>
>
> I find this commentary on drive-by reviews interesting.  Personally, I don't find going to the web interface to be a problem at all but that may be because my e-mail is also in my web browser and it's as easy as clicking a link.  Also, since I'm an active contributor who's likely to be making MRs and commenting on various MRs on a regular basis, I'm already on the MR page looking at it.  If you randomly scrolled through the MR list in the same way you randomly scroll through the mailing list, would you be equally inclined to give drive-by reviews?  That's an honest hypothetical question.

Less so, but greater than 0.

My e-mail client is also web-based (gmail). I auto-archive all mailing
list email, and attach various labels like "mesa-dev" and "dri-devel"
(yeah, I'm creative).

I will frequently run through those emails looking at subjects of new
ones. I will also click into patches, and look at them for 0.5-3
seconds each (I've gotten good at this). If they're short, or I happen
to notice something, or they're interesting, or they're in "my
domain", I'll just reply. Otherwise I do nothing.

With a web UI... I wouldn't end up on it in the first place. I always
have an email client open. I don't have gitlab open. Even if I did,
I'd have to keep flipping between various projects I might be
interested in.

I also like to stay apprised of various goings on, like the various
display work going on in other drivers. Having it all stream through
email is convenient. If it's hidden behind some web UI ... I'll never
look at it.

Here's a practical example, even if it's not a 100% match for this
situation -- a company I formerly worked at had a vibrant mailing list
of ex-employees. Lots of traffic, job postings, etc. Then a
well-intentioned HR person at that company who managed the community
created an online job board and additional environment, with
additional logins, etc -- where posts, mailing lists, etc would go.
The job board posts are gone now, the new mailing lists never got
traffic since it no longer went to people's primary emails, and the
community is now dead. They rolled it all back, but it never
recovered.

  -ilia