[Mesa-dev] [PATCH 2/5] ac/nir: restrict fmask lookup to image load intrinsics

[Bas Nieuwenhuizen]

On Tue, Dec 18, 2018, 9:57 PM Samuel Pitoiset <samuel.pitoiset at gmail.com
wrote:

> We don't ever want to do the fmask lookup on a atomic or
> store, the fmask should have been decompressed if the
> surface has been moved to IMAGE_LAYOUT.
>

Clarify the description to be a *storage* image layout?

>
> Original patch by Dave Airlie.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c
> b/src/amd/common/ac_nir_to_llvm.c
> index 225c930d896..0f57dc7eeb4 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -2243,7 +2243,7 @@ static void get_image_coords(struct ac_nir_context
> *ctx,
>         bool gfx9_1d = ctx->ac.chip_class >= GFX9 && dim ==
> GLSL_SAMPLER_DIM_1D;
>         count = image_type_to_components_count(dim, is_array);
>
> -       if (is_ms) {
> +       if (is_ms && instr->intrinsic == nir_intrinsic_image_deref_load) {
>                 LLVMValueRef fmask_load_address[3];
>                 int chan;
>
> --
> 2.20.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181220/f82cf8c6/attachment-0001.html>