[Mesa-dev] [PATCH 3/3] radeonsi: make use of ac_are_tessfactors_def_in_all_invocs()

[Marek Olšák]

Nice. For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri <tarceri at itsqueeze.com>
wrote:

> ---
>  src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c
> b/src/gallium/drivers/radeonsi/si_shader_nir.c
> index b81bea00b8..931d41245d 100644
> --- a/src/gallium/drivers/radeonsi/si_shader_nir.c
> +++ b/src/gallium/drivers/radeonsi/si_shader_nir.c
> @@ -285,14 +285,8 @@ void si_nir_scan_tess_ctrl(const struct nir_shader
> *nir,
>         if (nir->info.stage != MESA_SHADER_TESS_CTRL)
>                 return;
>
> -       /* Initial value = true. Here the pass will accumulate results from
> -        * multiple segments surrounded by barriers. If tess factors aren't
> -        * written at all, it's a shader bug and we don't care if this
> will be
> -        * true.
> -        */
> -       out->tessfactors_are_def_in_all_invocs = true;
> -
> -       /* TODO: Implement scanning of tess factors, see tgsi backend. */
> +       out->tessfactors_are_def_in_all_invocs =
> +               ac_are_tessfactors_def_in_all_invocs(nir);
>  }
>
>  void si_nir_scan_shader(const struct nir_shader *nir,
> --
> 2.19.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181221/e6e5fbcd/attachment.html>