[Mesa-dev] [PATCH 3/4] vbo: add comments on the VBO draw function typedefs

[Brian Paul]

On 02/01/2018 03:49 AM, Ilia Mirkin wrote:
> On Wed, Jan 31, 2018 at 10:39 PM, Brian Paul <brianp at vmware.com> wrote:
>> And rename indirect_params -> indirect_draw_count_buffer and
>> indirect_params_offset -> indirect_draw_count_offset to be more
>> specific.
>> ---
>>   src/mesa/vbo/vbo.h | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 55 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h
>> index 164477f..59c6a06 100644
>> --- a/src/mesa/vbo/vbo.h
>> +++ b/src/mesa/vbo/vbo.h
>> @@ -119,6 +119,43 @@ void
>>   vbo_save_EndCallList(struct gl_context *ctx);
>>
>>
>> +/**
>> + * For indirect array drawing:
>> + *
>> + *    typedef struct {
>> + *       GLuint count;
>> + *       GLuint primCount;
>> + *       GLuint first;
>> + *       GLuint reservedMustBeZero;
> 
> Actually that's baseInstance both here and below.

In GL 4.2 and later.  I'll add a comment about that.  Thanks.

-Brian

> 
>> + *    } DrawArraysIndirectCommand;
>> + *
>> + * For indirect indexed drawing:
>> + *
>> + *    typedef struct {
>> + *       GLuint count;
>> + *       GLuint primCount;
>> + *       GLuint firstIndex;
>> + *       GLint  baseVertex;
>> + *       GLuint reservedMustBeZero;
>> + *    } DrawElementsIndirectCommand;
>> + */