[Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

Roland Scheidegger sroland at vmware.com
Fri Feb 2 08:02:18 UTC 2018


Are you sure of that? You only get 11 stride bits to program, and they
are in bytes. Therefore I can't see how you could program 2048 (unless
the hw would interpet 0 as 2048 but I think stride 0 is valid there?).

Roland


Am 02.02.2018 um 07:23 schrieb Dave Airlie:
> From: Dave Airlie <airlied at redhat.com>
> 
> This fixes:
> KHR-GL45.limits.max_vertex_attrib_stride
> looks like a typo from the first commit.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/r600/r600_pipe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
> index 6c021e568d..29fadf6200 100644
> --- a/src/gallium/drivers/r600/r600_pipe.c
> +++ b/src/gallium/drivers/r600/r600_pipe.c
> @@ -451,7 +451,7 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>  		return family >= CHIP_CEDAR ? 4 : 1;
>  
>  	case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
> -		return 2047;
> +		return 2048;
>  
>  	/* Texturing. */
>  	case PIPE_CAP_MAX_TEXTURE_2D_LEVELS:
> 



More information about the mesa-dev mailing list