[Mesa-dev] [PATCH 0/3] Fix and tweak to the VAO v2

Brian Paul brianp at vmware.com
Tue Feb 6 00:03:15 UTC 2018


On 02/05/2018 03:19 PM, Mathias.Froehlich at gmx.net wrote:
> From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
> 
> Hi Brian,
> 
> Actually after incorporating your review requests to set
> gl_vertex_array::Size and gl_vertex_array::Ptr to zero, radeonsi
> started to assert in Bitmap/CopyPixels/DrawPixels.
Which assertion, exactly?  And what test triggers it?  I'd like to take 
a close look with the llvmpipe/svga drivers just so I understand what's 
happening.

-Brian

> 
> So, here the updated series including the requested changes.
> And additoinally for review the change to fix the mentioned asserts
> in several piglit tests.
> 
> Please review!
> 
> best
> 
> Mathias
> 
> 
> Mathias Fröhlich (3):
>    mesa: Fix VAO buffer object tracking.
>    mesa: Mute arrays for Bitmap/CopyPixels/DrawPixels callbacks.
>    mesa: Only update enabled VAO gl_vertex_array entries.
> 
>   src/mesa/main/drawpix.c | 10 ++++++++++
>   src/mesa/main/varray.c  | 10 ++++++----
>   src/mesa/main/varray.h  | 29 ++++++++++++++++++-----------
>   3 files changed, 34 insertions(+), 15 deletions(-)
> 



More information about the mesa-dev mailing list